fix: [IOPID-0000] apply fix on saml request decode #7397
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7397 +/- ##
=======================================
Coverage 59.86% 59.86%
=======================================
Files 1865 1865
Lines 40603 40603
Branches 9307 9369 +62
=======================================
Hits 24308 24308
+ Misses 16222 16209 -13
- Partials 73 86 +13
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request introduces a small fix to the
lollipopSamlVerifyfunction ints/features/lollipop/utils/login.tsto improve compatibility when decoding SAML requests.pako.inflateRawfrom aBufferto aUint8Arrayto ensure correct handling of binary data when decoding base64-encoded SAML requests.How to test
Run the application and try to decode saml request on login flow